Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slash makes URL invalid #3887

Closed
Tracked by #3963
MichalTuleja opened this issue Oct 25, 2021 · 0 comments · Fixed by #4052
Closed
Tracked by #3963

Trailing slash makes URL invalid #3887

MichalTuleja opened this issue Oct 25, 2021 · 0 comments · Fixed by #4052
Assignees
@isalga
Labels
type: bug
Milestone
Sprint 65

Comments

@MichalTuleja
Copy link
Contributor

Expected behavior

Desktop connects to Lisk Service with and without the trailing slash at the end of the URL.

Actual behavior

Trailing slash makes the URL invalid in the custom service node dialog.

Compare:

https://mainnet-service-staging.lisk.com/ vs https://mainnet-service-staging.lisk.com

Steps to reproduce

Screenshot 2021-10-25 at 12 24 01

Screenshot 2021-10-25 at 12 23 52

Which version(s) does this affect? (Environment, OS, etc...)

2.0.2
@sridharmeganathan sridharmeganathan added this to the Sprint 65 milestone Jan 4, 2022
@sridharmeganathan sridharmeganathan mentioned this issue Jan 4, 2022
Closed
37 tasks
@isalga isalga mentioned this issue Jan 10, 2022
Merged
isalga pushed a commit that referenced this issue Jan 11, 2022
@ManuGowda
Fix invalid URL - Closes #3887 (#4052)
3cd82c1 
* Remove

* Create removeTrailingSlash function

* Use regex and add documentation

* Only setAddress for last input

Co-authored-by: Manu <ManuGowda@users.noreply.github.com>
reyraa pushed a commit that referenced this issue Jan 24, 2022
@ManuGowda @reyraa
Fix invalid URL - Closes #3887 (#4052)
26c1f54 
* Remove

* Create removeTrailingSlash function

* Use regex and add documentation

* Only setAddress for last input

Co-authored-by: Manu <ManuGowda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isalga isalga

Labels
type: bug
Projects
None yet
Milestone
Sprint 65
Development

Successfully merging a pull request may close this issue.

Fix invalid URL - Closes #3887 LiskHQ/lisk-desktop
4 participants
@isalga @MichalTuleja @ManuGowda @sridharmeganathan