Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Ledger HW implementation to Core v3 API changes #3833

Closed
Tracked by #3699
reyraa opened this issue Oct 5, 2021 · 0 comments
Closed
Tracked by #3699

Adapt Ledger HW implementation to Core v3 API changes #3833

reyraa opened this issue Oct 5, 2021 · 0 comments

Comments

@reyraa
Copy link
Contributor

reyraa commented Oct 5, 2021

Description

In order to enable user to access their funds using a Ledger hardware wallet, we should refactor our hardware wallet manager to adapt to the Core v3 API changes.
This involves refactoring Ledger specific utilities. although it might affect the rest of the pipeline.

Motivation

Reinstate hardware wallet support

Acceptance criteria

  • Manufacturer specific changes must be limited to this directory.
  • The methods exposed should have a similar signature as those in Trezor.
  • Unit test coverage is required.
  • User should be able to create transactions using Ledger nano s

Additional Information

Currently Ledger Nano S HW is ready for development and testing, however Ledger Nano X is not ready for development and testing, however, we expect both should work for same code base. We will test Ledger Nano X once its ready in developer mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants