Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate unit test coverage for Redux store middleware #3796

Closed
Tracked by #3794
ikem-legend opened this issue Sep 15, 2021 · 1 comment · Fixed by #3848
Closed
Tracked by #3794

Reinstate unit test coverage for Redux store middleware #3796

ikem-legend opened this issue Sep 15, 2021 · 1 comment · Fixed by #3848
Assignees
@gadjacobs
Labels
type: test
Milestone
Sprint 60

Comments

@ikem-legend
Copy link
Member

Description

The following files have been added to the coverage ignore list as a compromise to meet the deadlines. Since we have released v2.0.0, we'd like to increase the test coverage of the following files:

Middleware

  • src/store/middlewares/network.js
  • src/store/middlewares/account.js

Acceptance Criteria

  • All unit tests must meet the coverage threshold
  • All functions must be unit tested
@welcome
Copy link

welcome bot commented Sep 15, 2021

Thanks for opening your first issue here! Be sure to follow the issue template for bug report or feature request!

@ManuGowda ManuGowda mentioned this issue Sep 15, 2021
Closed
8 tasks
@sridharmeganathan sridharmeganathan added this to the Sprint 59 milestone Sep 29, 2021
@gadjacobs gadjacobs mentioned this issue Oct 11, 2021
Merged
reyraa added a commit that referenced this issue Oct 14, 2021
@reyraa
Merge pull request #3848 from LiskHQ/3796-unit-test-coverage-for-redu…
9fdd539 
…x-middlewares

Unit test coverage for redux middlewares - Closes #3796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gadjacobs gadjacobs

Labels
type: test
Projects
None yet
Milestone
Sprint 60
Development

Successfully merging a pull request may close this issue.

Unit test coverage for redux middlewares - Closes #3796 LiskHQ/lisk-desktop
3 participants
@gadjacobs @ikem-legend @sridharmeganathan