Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app doesn't open launch protocol targets #3657

Closed
Tracked by #3826
sridharmeganathan opened this issue Jun 29, 2021 · 0 comments · Fixed by #3919
Closed
Tracked by #3826

The app doesn't open launch protocol targets #3657

sridharmeganathan opened this issue Jun 29, 2021 · 0 comments · Fixed by #3919
Assignees
Milestone

Comments

@sridharmeganathan
Copy link
Contributor

sridharmeganathan commented Jun 29, 2021

Expected behavior

Lisk Desktop should support deep linking using launch protocol. Users must be able to open Lisk Desktop and navigate to specific pages by clicking on external links such as:

  • Lisk://wallet
  • Lisk://delegates
  • Lisk://transactions
  • Lisk://blocks
  • Lisk://accounts
  • Lisk://network

Users should also be able to open modal screens with given parameters:

  • Lisk://wallet?modal=votingQueue&unvotes=genesis_3,genesis_4&votes=oqvpf,genesis_6,genesis_7

    • This URL will open vote queue and add 3 votes and 2 unvotes without specifying the vote amount.
  • Lisk://wallet?modal=send&address=lskdxc4ta5j43jp9ro3f8zqbxta9fn6jwzjucw7yt&amount=12&message=sample_message

    • This URL will open the send screen and fill the form with given parameters.

The rest of the modals should be supported similarly.

  • Ensure the open launch protocol targets works on Mac, Windows, Linux OS

Actual behavior

At the moment launch protocol runs the app, but doesn't redirect to the correct screen.

Which version(s) does this affect? (Environment, OS, etc...)

Mac, v2.0.0

@isalga isalga assigned isalga and unassigned isalga Jul 20, 2021
@isalga isalga self-assigned this Jul 28, 2021
@reyraa reyraa changed the title Request LSK Link not opening the respective page The app doesn't open launch protocol tagets Jul 30, 2021
@reyraa reyraa added this to the Sprint 54 milestone Jul 30, 2021
@sridharmeganathan sridharmeganathan modified the milestones: Sprint 54, Sprint 55 Aug 4, 2021
@sridharmeganathan sridharmeganathan removed this from the Sprint 55 milestone Aug 18, 2021
@karmacoma karmacoma added this to the Sprint 56 milestone Aug 22, 2021
@sridharmeganathan sridharmeganathan modified the milestones: Sprint 56, Sprint 57 Sep 1, 2021
@karmacoma karmacoma changed the title The app doesn't open launch protocol tagets The app doesn't open launch protocol targets Sep 14, 2021
@sridharmeganathan sridharmeganathan removed this from the Sprint 57 milestone Sep 15, 2021
@sridharmeganathan sridharmeganathan added this to the Sprint 61 milestone Oct 27, 2021
@gadjacobs gadjacobs self-assigned this Oct 27, 2021
ManuGowda added a commit that referenced this issue Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants