Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network flags are missing #2840

Closed
reyraa opened this issue Mar 27, 2020 · 0 comments · Fixed by #2841
Closed

Network flags are missing #2840

reyraa opened this issue Mar 27, 2020 · 0 comments · Fixed by #2841
Assignees
@reyraa
Labels
type: bug
Milestone
Sprint 20

Comments

@reyraa
Copy link
Contributor

reyraa commented Mar 27, 2020

Expected behavior

All peers whose location is provided by Lisk Service should have a flag in peers list on Network monitor page.

Actual behavior

Some countries are shown as unkonwn (-) but their location is actually provided by the API.
This is a misalignment between flags.css and flags.js.

Steps to reproduce

Compare the list with the API response
@reyraa reyraa self-assigned this Mar 27, 2020
@reyraa reyraa added this to the Sprint 20 milestone Mar 27, 2020
@reyraa reyraa mentioned this issue Mar 27, 2020
Merged
reyraa added a commit that referenced this issue Mar 27, 2020
@reyraa
Merge pull request #2841 from LiskHQ/2840-fix-network-flags
f5b21f9 
Fix missing country flags on Network monitor - Closes #2840
@sridharmeganathan sridharmeganathan mentioned this issue May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyraa reyraa

Labels
type: bug
Projects
None yet
Milestone
Sprint 20
Development

Successfully merging a pull request may close this issue.

Fix missing country flags on Network monitor - Closes #2840 LiskHQ/lisk-desktop
1 participant
@reyraa