Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide unfinished UI elements #206

Closed
slaweet opened this issue Jan 15, 2018 · 0 comments
Closed

Hide unfinished UI elements #206

slaweet opened this issue Jan 15, 2018 · 0 comments
Assignees
@slaweet

Comments

@slaweet
Copy link
Contributor

slaweet commented Jan 15, 2018 •
edited
Loading

Expected behaviour

Register delegate, Register the second passphrase, Buy LSK, Language switcher should be disabled/commented.

E2E tests for Register delegate, Register the second passphrase can be changed to use the url of the modals
E2E of language switcher can be disabled.

Actual behaviour

There are the following UI elements that open modals without redesign

  • Register delegate
  • Register the second passphrase
  • Buy LSK

Then there is the language switch, but we decided that the relaunch will have only English.

  • Language switch
@slaweet slaweet self-assigned this Jan 15, 2018
slaweet added a commit that referenced this issue Jan 17, 2018
@slaweet
Hide unfinished UI elements - Closes #206
10795b0
slaweet added a commit that referenced this issue Jan 17, 2018
@slaweet
Hide unfinished UI elements - Closes #206
95abeb1
slaweet added a commit that referenced this issue Jan 17, 2018
@slaweet
Hide unfinished UI elements - Closes #206
3f1925e
slaweet added a commit that referenced this issue Jan 17, 2018
@slaweet
Hide unfinished UI elements - Closes #206
88c952e
slaweet added a commit that referenced this issue Jan 17, 2018
@slaweet
Hide unfinished UI elements - Closes #206
c9eb37a
slaweet added a commit that referenced this issue Jan 17, 2018
@slaweet
Hide unfinished UI elements - Closes #206
c43f043
@slaweet slaweet mentioned this issue Jan 17, 2018
Merged
slaweet added a commit that referenced this issue Jan 17, 2018
@slaweet
Hide unfinished UI elements - Closes #206
77075e5
slaweet added a commit that referenced this issue Jan 17, 2018
@slaweet
Hide unfinished UI elements - Closes #206
a8bdd9a
slaweet added a commit that referenced this issue Jan 17, 2018
@slaweet
Hide unfinished UI elements - Closes #206
3e4da6b
slaweet added a commit that referenced this issue Jan 19, 2018
@slaweet
Disable flaky registerSecondPassphrase e2e test
dfb8d21 
because the feature will be disabled anyway in #206
@slaweet slaweet mentioned this issue Jan 19, 2018
Merged
slaweet added a commit that referenced this issue Jan 19, 2018
@slaweet
Disable flaky registerSecondPassphrase e2e test
e670440 
because the feature will be disabled anyway in #206
slaweet added a commit that referenced this issue Jan 19, 2018
@slaweet
Disable flaky registerSecondPassphrase e2e test
8f922e0 
because the feature will be disabled anyway in #206
slaweet added a commit that referenced this issue Jan 19, 2018
@slaweet
Merge pull request #213 from LiskHQ/206-hide-unfinished-ui
1be9e69 
Hide unfinished UI elements - Closes #206
slaweet added a commit that referenced this issue Jan 19, 2018
@slaweet
Disable flaky registerSecondPassphrase e2e test
c8719e2 
because the feature will be disabled anyway in #206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slaweet slaweet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slaweet