Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engines property to pacake.json to avoid using a problematic node version #1487

Closed
osvaldovega opened this issue Nov 14, 2018 · 1 comment
Assignees

Comments

@osvaldovega
Copy link
Contributor

The package.json does not have the engines property set what indicates that any node version can be use, this is not correct.

Use any version of node could cause problem at the moment to install the packages and then the app and tests can present a problematic behavior.

Description of the problem

package.json does not have set the engines property to know what node version to use.

Suggested solution

include the engine property in the node version and make that before install the packages check the current node version.

@osvaldovega osvaldovega self-assigned this Nov 14, 2018
@osvaldovega osvaldovega changed the title Add node engines to pacake.json to avoid using a problematic node version Add engines property to pacake.json to avoid using a problematic node version Nov 14, 2018
osvaldovega added a commit that referenced this issue Nov 14, 2018
…kage.json

Add engines property to package.json - Closes #1487
@osvaldovega
Copy link
Contributor Author

Issue fixed in PR #1489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant