Merge pull request #5584 from LiskHQ/update-notarization-variables

Updated notarization variables to use environment variables
LiskHQ · May 16, 2024 · ef202ed · ef202ed
2 parents b42c988 + ab574cb
commit ef202ed
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 2 deletions.
diff --git a/.env.example b/.env.example
@@ -1 +1,2 @@
 REACT_APP_MAPBOX_ACCESS_TOKEN=
+APPLE_TEAM_ID=
diff --git a/.eslintrc b/.eslintrc
@@ -8,7 +8,8 @@
     "PRODUCTION": true,
     "LISK_DOMAIN": true,
     "REACT_APP_DEFAULT_NETWORK": true,
-    "REACT_APP_MAPBOX_ACCESS_TOKEN": true
+    "REACT_APP_MAPBOX_ACCESS_TOKEN": true,
+    "APPLE_TEAM_ID": true
   },
   "env": {
     "es2020": true,

diff --git a/package.json b/package.json
@@ -84,7 +84,7 @@
       "entitlements": "build/entitlements.plist",
       "entitlementsInherit": "build/entitlements.plist",
       "notarize": {
-        "teamId": ""
+        "teamId": "${APPLE_TEAM_ID}"
       },
       "target": {
         "target": "default",

diff --git a/setup/config/webpack.config.react.js b/setup/config/webpack.config.react.js
@@ -106,6 +106,7 @@ const config = {
       LISK_DOMAIN: '"https://lisk.com"',
       REACT_APP_DEFAULT_NETWORK: `"${process.env.DEFAULT_NETWORK}"`,
       REACT_APP_MAPBOX_ACCESS_TOKEN: `"${process.env.REACT_APP_MAPBOX_ACCESS_TOKEN}"`,
+      APPLE_TEAM_ID: `"${process.env.APPLE_TEAM_ID}"`,
     }),
     new StyleLintPlugin({
       context: `${path.resolve(__dirname, '../../src')}`,

diff --git a/setup/jest.config.js b/setup/jest.config.js
@@ -347,6 +347,7 @@ module.exports = {
     VERSION: '',
     REACT_APP_DEFAULT_NETWORK: 'undefined',
     REACT_APP_MAPBOX_ACCESS_TOKEN: 'pk.eyJ1Ij',
+    APPLE_TEAM_ID: '',
     LISK_ENABLE_DEV_TOOL: false,
     LISK_DOMAIN: 'https://lisk.com',
   },