Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement multisignature pool cleanup - Closes #176 #846

Merged

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Nov 2, 2021

What was the problem?

This PR resolves #176

How was it

  • Add job named multisig.cleanup.expired
  • Add job named multisig.cleanup.rejected
  • Add implementation to remove transactions with expiration dates older than the current timestamp + 29 days
  • Add implementation to remove transactions with flag rejected: true and modification dates older than the current timestamp + 29 days

How was it tested?

Local + Jenkins

@nagdahimanshu nagdahimanshu self-assigned this Nov 2, 2021
@nagdahimanshu nagdahimanshu linked an issue Nov 2, 2021 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2021

CLA assistant check
All committers have signed the CLA.

services/transaction/config.js Outdated Show resolved Hide resolved
services/transaction/shared/dbMaintenance.js Outdated Show resolved Hide resolved
Copy link
Contributor

@MichalTuleja MichalTuleja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi merged commit 81f7211 into development-0.6.0 Nov 5, 2021
@sameersubudhi sameersubudhi deleted the 176-implement-multisignature-pool-cleanup branch November 5, 2021 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement multisignature pool cleanup
4 participants