This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Implement multisignature pool cleanup - Closes #176 #846
Merged
sameersubudhi
merged 12 commits into
development-0.6.0
from
176-implement-multisignature-pool-cleanup
Nov 5, 2021
Merged
Implement multisignature pool cleanup - Closes #176 #846
sameersubudhi
merged 12 commits into
development-0.6.0
from
176-implement-multisignature-pool-cleanup
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameersubudhi
suggested changes
Nov 2, 2021
5 tasks
…rvice into 176-implement-multisignature-pool-cleanup
MichalTuleja
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
sameersubudhi
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #176
How was it
multisig.cleanup.expired
multisig.cleanup.rejected
rejected
:true
and modification dates older than the current timestamp + 29 daysHow was it tested?
Local + Jenkins