Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Improve API client usage in interoperability example app scripts #9191

Conversation

bobanm
Copy link
Contributor

@bobanm bobanm commented Dec 14, 2023

What was the problem?

This PR resolves #9190

How was it solved?

Simplified sidechain_registration script to let API client directly handle

  • fetching node's chain ID
  • fetching account's current nonce
  • deriving public key and address
  • fetching command's params schema and encoding params
  • signing transactions
  • sending transactions using client.transaction.send() method

How was it tested?

The updated script provides the same results as the previous one.

@bobanm bobanm self-assigned this Dec 14, 2023
@bobanm bobanm marked this pull request as draft December 14, 2023 08:13
@bobanm bobanm changed the title Improve API client usage in iteroperability example app scripts Improve API client usage in interoperability example app scripts Dec 14, 2023
@ishantiw ishantiw marked this pull request as ready for review December 19, 2023 09:57
@ishantiw ishantiw merged commit 2c17b70 into development Dec 19, 2023
8 of 9 checks passed
@ishantiw ishantiw deleted the 9190-improve-api-client-usage-in-interop-example-app-scripts branch December 19, 2023 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interoperability example app scripts are not using the full power of API client
3 participants