Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Use address instead of public key #9157

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Use address instead of public key #9157

merged 1 commit into from
Nov 24, 2023

Conversation

ishantiw
Copy link
Contributor

@ishantiw ishantiw commented Nov 24, 2023

What was the problem?

This PR resolves #9156

How was it solved?

  • Use address instead of publicKey
  • Always use Lisk32 address for cross chain fee

How was it tested?

  • Run interop examples setup

@ishantiw ishantiw requested a review from Phanco November 24, 2023 16:54
@ishantiw ishantiw self-assigned this Nov 24, 2023
@ishantiw ishantiw changed the title 🐛 Use address instead of public key Use address instead of public key Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #9157 (cb3d02b) into hotfix/6.0.1 (9869bac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           hotfix/6.0.1    #9157   +/-   ##
=============================================
  Coverage         83.53%   83.53%           
=============================================
  Files               606      606           
  Lines             22839    22842    +3     
  Branches           3367     3367           
=============================================
+ Hits              19078    19081    +3     
  Misses             3761     3761           
Files Coverage Δ
...ain-connector-plugin/src/chain_connector_plugin.ts 79.00% <ø> (ø)
...lisk-framework-chain-connector-plugin/src/utils.ts 79.54% <100.00%> (+1.49%) ⬆️

@ishantiw ishantiw merged commit 57f8f20 into hotfix/6.0.1 Nov 24, 2023
10 checks passed
@ishantiw ishantiw deleted the 9156-fix-address branch November 24, 2023 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants