-
Notifications
You must be signed in to change notification settings - Fork 455
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #9155 +/- ##
===============================================
- Coverage 84.70% 84.66% -0.05%
===============================================
Files 656 657 +1
Lines 24138 24071 -67
Branches 3500 3492 -8
===============================================
- Hits 20447 20379 -68
- Misses 3691 3692 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments around exports
… into 9154-nft-module-typedocs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Tschakki 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to re-export the types
specifically from framework/src/index.ts
file instead of using export *
otherwise its not exported from the package when its built.
Please revert all the changes related to re-exporting types and export them individually.
… into 9154-nft-module-typedocs
What was the problem?
This PR ...
NFT module
#9154How was it tested?
npx typedoc
open docs/typedoc/index.html
https://liskhq.github.io/lisk-docs/lisk-sdk/references/typedoc/modules/lisk_framework.html