Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update lisk-codec to check int range during write #9010

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

Phanco
Copy link
Contributor

@Phanco Phanco commented Sep 19, 2023

What was the problem?

This PR resolves #8968

How was it solved?

How was it tested?

@Phanco Phanco self-assigned this Sep 19, 2023
@Phanco Phanco force-pushed the 8968-range-check-for-writing-codec branch from ead2caa to aaca8df Compare September 19, 2023 14:04
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #9010 (aaca8df) into release/6.1.0 (8b2339d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head aaca8df differs from pull request most recent head 3ce7c2f. Consider uploading reports for the commit 3ce7c2f to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.1.0    #9010   +/-   ##
==============================================
  Coverage          84.36%   84.37%           
==============================================
  Files                650      650           
  Lines              24017    24031   +14     
  Branches            3490     3494    +4     
==============================================
+ Hits               20261    20275   +14     
  Misses              3756     3756           
Files Changed Coverage
elements/lisk-codec/src/varint.ts 100.00%

@Phanco Phanco requested review from shuse2 and ishantiw September 19, 2023 15:59
@Phanco Phanco marked this pull request as ready for review September 19, 2023 15:59
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good to me but it includes unrelated changes

@Phanco Phanco requested a review from shuse2 September 20, 2023 09:31
@ishantiw ishantiw enabled auto-merge (squash) September 20, 2023 14:31
@ishantiw ishantiw merged commit 3db42a3 into release/6.1.0 Sep 20, 2023
@ishantiw ishantiw deleted the 8968-range-check-for-writing-codec branch September 20, 2023 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants