Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Lisk Commander generates README with depreciated content #8919

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Aug 31, 2023

What was the problem?

This PR resolves #8887

How was it solved?

Update outdated terminologies

How was it tested?

Tested manually via commander

@Incede Incede requested a review from shuse2 August 31, 2023 22:12
@Incede Incede self-assigned this Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #8919 (fca724c) into release/6.0.0 (fbf48ba) will not change coverage.
The diff coverage is n/a.

❗ Current head fca724c differs from pull request most recent head a6eff6d. Consider uploading reports for the commit a6eff6d to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #8919   +/-   ##
==============================================
  Coverage          83.61%   83.61%           
==============================================
  Files                601      601           
  Lines              22520    22520           
  Branches            3319     3323    +4     
==============================================
  Hits               18829    18829           
  Misses              3691     3691           

Copy link
Contributor

@TalhaMaliktz TalhaMaliktz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@ishantiw ishantiw enabled auto-merge (squash) September 1, 2023 14:25
@ishantiw ishantiw merged commit a12b87f into release/6.0.0 Sep 1, 2023
8 checks passed
@ishantiw ishantiw deleted the 8887-commander-terminology branch September 1, 2023 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants