This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 455
Align genesis schema and processing with lip auth #8846
Merged
ishantiw
merged 5 commits into
release/6.0.0
from
8842-align-genesis-schema-and-processing-with-lip-auth
Aug 15, 2023
Merged
Align genesis schema and processing with lip auth #8846
ishantiw
merged 5 commits into
release/6.0.0
from
8842-align-genesis-schema-and-processing-with-lip-auth
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.0.0 #8846 +/- ##
=================================================
+ Coverage 83.27% 83.38% +0.10%
=================================================
Files 593 596 +3
Lines 22254 22433 +179
Branches 3252 3312 +60
=================================================
+ Hits 18532 18705 +173
- Misses 3722 3728 +6
|
…align-genesis-schema-and-processing-with-lip-auth
vjaiman
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good.
…align-genesis-schema-and-processing-with-lip-auth
ishantiw
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a minor naming suggestions but approving from my end
ishantiw
deleted the
8842-align-genesis-schema-and-processing-with-lip-auth
branch
August 15, 2023 09:06
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8842
How was it solved?
Renamed schema entity names
How was it tested?
Unit Tests updated and passed