Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Align genesis schema and processing with lip auth #8846

Merged

Conversation

Phanco
Copy link
Contributor

@Phanco Phanco commented Aug 11, 2023

What was the problem?

This PR resolves #8842

How was it solved?

Renamed schema entity names

How was it tested?

Unit Tests updated and passed

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #8846 (2bd1270) into release/6.0.0 (c49607a) will increase coverage by 0.10%.
Report is 138 commits behind head on release/6.0.0.
The diff coverage is 89.62%.

❗ Current head 2bd1270 differs from pull request most recent head f9e4ea5. Consider uploading reports for the commit f9e4ea5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #8846      +/-   ##
=================================================
+ Coverage          83.27%   83.38%   +0.10%     
=================================================
  Files                593      596       +3     
  Lines              22254    22433     +179     
  Branches            3252     3312      +60     
=================================================
+ Hits               18532    18705     +173     
- Misses              3722     3728       +6     
Files Changed Coverage Δ
commander/src/base.ts 65.38% <0.00%> (-24.09%) ⬇️
commander/src/utils/genesis_creation.ts 69.23% <ø> (+38.46%) ⬆️
commander/test/helpers/transactions.ts 96.00% <ø> (-0.16%) ⬇️
elements/lisk-api-client/src/codec.ts 67.51% <ø> (ø)
elements/lisk-chain/src/schema.ts 100.00% <ø> (ø)
elements/lisk-p2p/src/schema.ts 100.00% <ø> (ø)
elements/lisk-transaction-pool/src/index.ts 0.00% <0.00%> (ø)
...n-connector-plugin/src/active_validators_update.ts 80.35% <0.00%> (ø)
...k-framework-dashboard-plugin/src/plugin/schemas.ts 100.00% <ø> (ø)
...lisk-framework-faucet-plugin/src/plugin/schemas.ts 100.00% <ø> (ø)
... and 45 more

... and 95 files with indirect coverage changes

@Phanco Phanco marked this pull request as ready for review August 11, 2023 13:27
@Phanco Phanco self-assigned this Aug 11, 2023
…align-genesis-schema-and-processing-with-lip-auth
@ishantiw ishantiw requested review from vjaiman and removed request for gkoumout August 14, 2023 09:58
Copy link

@vjaiman vjaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good.

…align-genesis-schema-and-processing-with-lip-auth
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a minor naming suggestions but approving from my end

framework/src/modules/auth/module.ts Show resolved Hide resolved
framework/src/modules/auth/module.ts Outdated Show resolved Hide resolved
@ishantiw ishantiw enabled auto-merge (squash) August 15, 2023 08:43
@ishantiw ishantiw merged commit b07bdbb into release/6.0.0 Aug 15, 2023
8 checks passed
@ishantiw ishantiw deleted the 8842-align-genesis-schema-and-processing-with-lip-auth branch August 15, 2023 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants