-
Notifications
You must be signed in to change notification settings - Fork 455
Add authorize endpoint to chain connector plugin #8809
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.0.0 #8809 +/- ##
=================================================
- Coverage 83.36% 83.35% -0.01%
=================================================
Files 596 596
Lines 22402 22408 +6
Branches 3303 3304 +1
=================================================
+ Hits 18676 18679 +3
- Misses 3726 3729 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also log the error message here to let the user know that there is no key enabled
@ishantiw in that line, |
@shuse2 Oh I thought we are throwing error when key not enabled, I think its better to throw error and be logged here lisk-sdk/framework-plugins/lisk-framework-chain-connector-plugin/src/chain_connector_plugin.ts because if we only return the next line will assume that the CCU was sent and will save the last sent CCM where it was not really sent to the other chain. So in this case we can raise error and it will retry to create the CCU next time with the CCM that was not sent earlier |
@ishantiw good point! updated the PR to throw and log 🙇 |
What was the problem?
This PR resolves #8484
How was it solved?
authorize
endpointpassword
config from chain connector pluginHow was it tested?
./bin/run endpoint:invoke chainConnector_authorize '{"password": "1234", "enable": false}'