Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix plugin child process loading issue #8701

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

mosmartin
Copy link
Contributor

What was the problem?

This PR resolves #8629

How was it solved?

Refactored the code to get the keys from a map in the registerToBus() method.

How was it tested?

Manually tested by calling a plugin endpoint.

@mosmartin mosmartin requested review from bobanm and ishantiw July 6, 2023 22:35
@mosmartin mosmartin self-assigned this Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #8701 (ffb7fee) into release/6.0.0 (ba1d9d9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #8701      +/-   ##
=================================================
- Coverage          83.26%   83.26%   -0.01%     
=================================================
  Files                593      593              
  Lines              22276    22276              
  Branches            3296     3296              
=================================================
- Hits               18549    18548       -1     
- Misses              3727     3728       +1     
Impacted Files Coverage Δ
framework/src/controller/channels/ipc_channel.ts 7.75% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mosmartin mosmartin force-pushed the 8629-fix-plugin-child-process branch from cb95427 to ffb7fee Compare July 7, 2023 10:32
@ishantiw ishantiw enabled auto-merge (squash) July 7, 2023 12:39
@ishantiw ishantiw merged commit 4d4f362 into release/6.0.0 Jul 7, 2023
@ishantiw ishantiw deleted the 8629-fix-plugin-child-process branch July 7, 2023 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants