Update genesis block tests

[shuse2]

What was the problem?

This PR resolves #8136 and resolves #7237

How was it solved?

• Add missing genesis block related tests
• Created another issue Missing generator address and validatorsHash check on genesis block #8439 , which should be resolved in release branch

How was it tested?

N/A

[codecov]

Codecov Report

Merging #8440 (4dc8572) into development (72b4bb4) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 4dc8572 differs from pull request most recent head 896afe2. Consider uploading reports for the commit 896afe2 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           development    #8440   +/-   ##
============================================
  Coverage        83.35%   83.36%           
============================================
  Files              593      593           
  Lines            22265    22265           
  Branches          3255     3255           
============================================
+ Hits             18560    18562    +2     
+ Misses            3705     3703    -2     

see 6 files with indirect coverage changes

[AndreasKendziorra]

The following point from #8136 is still unaddressed:

There is no test for the stateRoot property. In particular, there is no test that expects that genesis block processing fails if the value of header.stateRoot in incorrect.

[AndreasKendziorra]

I left two additional review comments for a file, but they got somehow lost. So, I repeat them here:

• As stated in Unit test review genesis block processing (LIP 0060) #8136, the tests for signature are still not correct.
• Test for valid impliesMaxPrevotes (value must be true) is missing. More generally, a test for a valid genesis block missing.

[shuse2]

@AndreasKendziorra
Added valid genesis block case and merged the other PR into development, so the error message should be resolved on the branch already.

For the signature property, I made a comment on the issue 🙇

[AndreasKendziorra]

ok, looks all good. But what is with this one:

There is no test for the stateRoot property. In particular, there is no test that expects that genesis block processing fails if the value of header.stateRoot in incorrect.

I assume it also somehow done in lisk-db. But do we ensure somewhere that genesis block processing fails if lisk-db fails to validate the stateroot?

[shuse2]

@AndreasKendziorra i think i missed the comment. Added the relevant test 👍