This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix transactionInPool bug - Closes #707 #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diego-G
requested review from
karmacoma,
LucasIsasmendi,
MaciejBaj and
Isabello
|
Is this done and ready to be reviewed? If not can you close and open when it is ready for review? |
MaciejBaj
previously requested changes
Oct 4, 2017
test/unit/logic/transactions/pool.js
Outdated
| // Init transaction logic | ||
| async.auto({ | ||
| accountLogic: function (cb) { | ||
| modulesLoader.initLogicWithDb(AccountLogic, cb); |
There was a problem hiding this comment.
Please use initLogic instead of initLogicWithDb as database is not used in the test
test/unit/logic/transactions/pool.js
Outdated
|
|
||
| describe('receiveTransactions', function () { | ||
|
|
||
| it('should do nothing for empty array', function (done) { |
There was a problem hiding this comment.
Returing {} is not doing nothing
diego-G
dismissed
MaciejBaj’s stale review
New commit addressing requested comments :)
MaciejBaj
previously requested changes
Oct 5, 2017
diego-G
dismissed
MaciejBaj’s stale review
We will unify that in the refactor.
Isabello
previously approved these changes
Oct 5, 2017
MaciejBaj
previously approved these changes
Oct 5, 2017
|
@diego-G log an issue to track the unification. |
Isabello
previously approved these changes
Oct 5, 2017
Isabello
force-pushed
the
707-fix_transactionInPool
branch
from
19e3634 to
14ba571
Compare
Isabello
force-pushed
the
707-fix_transactionInPool
branch
from
14ba571 to
463b72e
Compare
diego-G
force-pushed
the
707-fix_transactionInPool
branch
from
6b0ea99 to
ef17865
Compare
diego-G
force-pushed
the
707-fix_transactionInPool
branch
from
ef17865 to
40c2dbf
Compare
…707-fix_transactionInPool # Conflicts: # test/unit/logic/transactionPool.js
Isabello
previously approved these changes
Oct 6, 2017
4miners
suggested changes
Oct 6, 2017
logic/transactionPool.js
Outdated
| @@ -101,7 +101,9 @@ TransactionPool.prototype.transactionInPool = function (id) { | |||
| self.bundled.index[id], | |||
| self.queued.index[id], | |||
| self.multisignature.index[id] | |||
| ].filter(Boolean).length > 0; | |||
| ].filter(function (inList) { | |||
There was a problem hiding this comment.
karmacoma
previously approved these changes
Oct 6, 2017
4miners
previously approved these changes
Oct 6, 2017
4miners
dismissed stale reviews from karmacoma, Isabello, and themself
via
9f1ac7f
Isabello
approved these changes
Oct 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the refactor on #561 is taking too long, we include small temporal fix with some tests. Hence it won't bother another builds anymore.
Closes #707