This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
🐛 Fix invalid init response - Closes #7260 #7281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ishantiw
approved these changes
Jul 7, 2022
shuse2
approved these changes
Jul 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7260
How was it solved?
Updated
ABIHandler.initto:bftBatchSizefrom injectedgenesisconfiguration.rpc.wsfrom injectedrpc.wsconfiguration.Updated
applicationConfigSchemato allow for a numericbftBatchSizevalue with minimum value of 1 and default set to 103.Updated
GenesisConfiginterface to allow for a numericbftBatchSize.Update configuration for
dev_netand anddpos-mainchain, to containbftBatchSizeproperty set to 103.Modified unit tests.
How was it tested?
Passing unit tests.