This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Remove insecure endpoints - Closes #457 #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejBaj
force-pushed
the
457-remove-insecure-endpoints
branch
from
30d4253 to
097fba8
Compare
Isabello
reviewed
Jul 19, 2017
| library.logger.debug('Received transaction ' + transaction.id + ' from public client'); | ||
| } else { | ||
| library.logger.debug('Received transaction ' + transaction.id + ' from peer ' + library.logic.peers.peersManager.getAddress(peer.nonce)); | ||
| } |
Isabello
reviewed
Jul 19, 2017
| @@ -77,6 +73,20 @@ describe('postTransactions', function () { | |||
| secret: node.gAccount.password, | |||
| amount: 100000000000, | |||
| recipientId: account.address | |||
| }, function (err, res) { | |||
| node.expect(err).to.be.null; | |||
| node.onNewBlock(done); | |||
- apply signatures tests in transport layer - rename transport layer tests from peers prefix - use lisk-js in functional tests when necessary
MaciejBaj
force-pushed
the
457-remove-insecure-endpoints
branch
from
097fba8 to
2ec7272
Compare
- use prototype in peersManager - don't use acceptable in returning peers list - use self.findGoodPeers in loader - introduce updatePeerStatus function
- apply signatures tests in transport layer - rename transport layer tests from peers prefix - use lisk-js in functional tests when necessary
…nto 457-remove-insecure-endpoints # Conflicts: # test/unit/logic/transaction.js
MaciejBaj
force-pushed
the
457-remove-insecure-endpoints
branch
2 times, most recently
from
92060ee to
fe0153d
Compare
diego-G
suggested changes
Jul 21, 2017
- add missing transport tests - add structure for tests in transport.transaction.main - remove tests relying on public endpoints
MaciejBaj
force-pushed
the
457-remove-insecure-endpoints
branch
from
fe0153d to
fc68a1c
Compare
diego-G
force-pushed
the
457-remove-insecure-endpoints
branch
from
7fe9860 to
253a9cc
Compare
diego-G
force-pushed
the
457-remove-insecure-endpoints
branch
from
253a9cc to
5aaffdb
Compare
diego-G
previously approved these changes
Jul 21, 2017
MaciejBaj
force-pushed
the
457-remove-insecure-endpoints
branch
from
bb71a5e to
e841ac2
Compare
MaciejBaj
force-pushed
the
446-ws-peers-rebased
branch
2 times, most recently
from
60e15f5 to
475992d
Compare
…emove-insecure-endpoints
diego-G
force-pushed
the
457-remove-insecure-endpoints
branch
from
14b3acb to
19363c8
Compare
Isabello
suggested changes
Jul 26, 2017
modules/multisignatures.js
Outdated
| @@ -63,6 +63,9 @@ function Multisignatures (cb, scope) { | |||
| * @todo test function!. | |||
| */ | |||
| Multisignatures.prototype.processSignature = function (tx, cb) { | |||
| if (!tx) { | |||
| return setImmediate(cb, 'Cannot process an empty signature.'); | |||
There was a problem hiding this comment.
Unable to process signature. Signature is undefined.
There was a problem hiding this comment.
something like this. Not sure on the wording myself.
modules/transport.js
Outdated
| @@ -195,6 +197,9 @@ __private.receiveTransactions = function (query, peer, extraLogMessage, cb) { | |||
| transactions = query.transactions; | |||
|
|
|||
| async.eachSeries(transactions, function (transaction, eachSeriesCb) { | |||
| if (!transaction) { | |||
| return setImmediate(eachSeriesCb, 'Cannot receive empty transaction'); | |||
There was a problem hiding this comment.
Unable to process signature. Signature is undefined.
| return trs; | ||
| }; | ||
|
|
||
| /** | ||
| * Obtains constant fee secondsignature. |
There was a problem hiding this comment.
This implies several changes coming from the helper constants. @Isabello Shall we follow the same pattern to multiSignature? https://github.com/LiskHQ/lisk/blob/457-remove-insecure-endpoints/helpers/constants.js#L15
There was a problem hiding this comment.
Ah damn. No lets not change this until later. Please log an issue about standardizing it to be camelCase if you don't mind.
Isabello
approved these changes
Jul 26, 2017
diego-G
approved these changes
Jul 26, 2017
SargeKhan
approved these changes
Jul 26, 2017
karmacoma
added
ready
and removed
in progress
type: bug
type: refactoring
type: test
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove insecure endpoints and move corresponding tests:
transportprefixcloses #457