Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add decode object - Closes #5236 & #5239 & #5218 #5350

Merged
merged 2 commits into from
May 25, 2020

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented May 20, 2020

What was the problem?

This PR resolves #5236, resolves #5239 and resolves #5218

How was it solved?

  • Add decode function
  • Add object reader
  • Add array reader

How was it tested?

  • Test against protocol specs

@shuse2 shuse2 self-assigned this May 20, 2020
@shuse2 shuse2 force-pushed the 5236-decode_object branch from c8cc8ab to e6be103 Compare May 20, 2020 17:51
@shuse2 shuse2 changed the title Add decode object - Closes #5236 & #5237 & #5217 Add decode object - Closes #5236 & #5239 & #5217 May 21, 2020
@shuse2 shuse2 marked this pull request as ready for review May 22, 2020 06:35
Base automatically changed from 5217-create_function_to_traverse_the_object_for_encoding to development May 25, 2020 14:30
@shuse2 shuse2 force-pushed the 5236-decode_object branch from e6be103 to 1add73a Compare May 25, 2020 14:40
✅ Add basic decode test

complete basic tests

benchmark
@shuse2 shuse2 force-pushed the 5236-decode_object branch from 1add73a to f247150 Compare May 25, 2020 14:50
@shuse2 shuse2 changed the title Add decode object - Closes #5236 & #5239 & #5217 Add decode object - Closes #5236 & #5239 & #5218 May 25, 2020
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

elements/lisk-codec/benchmark/decode.js Outdated Show resolved Hide resolved
elements/lisk-codec/benchmark/decode.js Show resolved Hide resolved
elements/lisk-codec/src/collection.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 requested a review from ishantiw May 25, 2020 15:22
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shuse2 shuse2 merged commit 612ca70 into development May 25, 2020
@shuse2 shuse2 deleted the 5236-decode_object branch May 25, 2020 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants