Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Create function to traverse the object for encoding - Closes #5217 & #5228 & #5235 #5322

Merged
merged 40 commits into from
May 25, 2020
Merged

Create function to traverse the object for encoding - Closes #5217 & #5228 & #5235 #5322

merged 40 commits into from
May 25, 2020

Conversation

pablitovicente
Copy link
Contributor

@pablitovicente pablitovicente commented May 13, 2020 •
edited
Loading

What was the problem?

This PR resolves #5217 resolves #5228 resolves #5235

How was it solved?

By implementing the items described in the issue

How was it tested?

  • Unit tests
  • For reviewing this PR follow the encoding section of LIP-0027

@pablitovicente pablitovicente self-assigned this May 13, 2020
@pablitovicente pablitovicente changed the title Create function to traverse the object for encoding - Closes #5217 & #5228 Create function to traverse the object for encoding - Closes #5217 & #5228 & #5235 May 15, 2020
@pablitovicente pablitovicente force-pushed the 5217-create_function_to_traverse_the_object_for_encoding branch from d4c50cf to 7807e83 Compare May 15, 2020 15:14
ManuGowda
ManuGowda reviewed May 20, 2020
View reviewed changes
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance everything LGTM. few suggestions.

elements/lisk-codec/src/codec.ts Outdated Show resolved Hide resolved
elements/lisk-codec/src/collection.ts Show resolved Hide resolved
elements/lisk-codec/src/collection.ts Outdated Show resolved Hide resolved
elements/lisk-codec/test/add_schema.spec.ts Outdated Show resolved Hide resolved
@pablitovicente pablitovicente requested a review from ManuGowda May 20, 2020 15:54
ManuGowda
ManuGowda reviewed May 22, 2020
View reviewed changes
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few questions and recommendations.

elements/lisk-codec/src/codec.ts Show resolved Hide resolved
elements/lisk-codec/src/codec.ts Show resolved Hide resolved
elements/lisk-codec/src/codec.ts Show resolved Hide resolved
elements/lisk-codec/src/codec.ts Show resolved Hide resolved
@pablitovicente pablitovicente marked this pull request as ready for review May 25, 2020 13:29
@shuse2 shuse2 merged commit 58705ef into development May 25, 2020
@shuse2 shuse2 deleted the 5217-create_function_to_traverse_the_object_for_encoding branch May 25, 2020 14:30
@shuse2 shuse2 mentioned this pull request Jul 13, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MaximeGagnebin MaximeGagnebin MaximeGagnebin approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

@shuse2 shuse2 shuse2 approved these changes

Assignees

@pablitovicente pablitovicente

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@pablitovicente @shuse2 @ManuGowda @MaximeGagnebin