Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Jest Integration tests are failing randomly - Closes # 4343 #4625

Merged
merged 8 commits into from
Dec 18, 2019

Conversation

nazarhussain
Copy link
Contributor

What was the problem?

Jest was running all tests parallel and in beforeAll of every test suite we creating a database and then running database migrations. When migrations run on so many databases in parallel it get slow.

Default timeout for jest is 5000, so beforeAll was throwing timeout error. And suspiciously instead of stopping that test suit, jest was running and was failing because database don't have complete migrations that time.

How did I solve it?

Increased the timeout to 10000 from 5000 only for integration tests.

How to manually test it?

Review checklist

@nazarhussain nazarhussain self-assigned this Dec 13, 2019
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, Minor comment.

Jenkinsfile.sdk Show resolved Hide resolved
Copy link
Contributor

@valamidev valamidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nazarhussain nazarhussain requested review from shuse2 and removed request for shuse2 December 17, 2019 13:25
@ManuGowda ManuGowda removed the request for review from shuse2 December 18, 2019 09:21
@ManuGowda ManuGowda merged commit a23f2a6 into development Dec 18, 2019
@ManuGowda ManuGowda deleted the 4343-jenkins-failing-tests branch December 18, 2019 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest Integration tests are failing randomly
4 participants