This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Jest Integration tests are failing randomly - Closes # 4343 #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
force-pushed
the
4343-jenkins-failing-tests
branch
from
December 13, 2019 14:26
f6b92a2
to
178af1d
Compare
ManuGowda
reviewed
Dec 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, Minor comment.
shuse2
reviewed
Dec 16, 2019
…dk into 4343-jenkins-failing-tests
ManuGowda
approved these changes
Dec 16, 2019
valamidev
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Jest was running all tests parallel and in
beforeAll
of every test suite we creating a database and then running database migrations. When migrations run on so many databases in parallel it get slow.Default timeout for jest is
5000
, sobeforeAll
was throwingtimeout
error. And suspiciously instead of stopping that test suit, jest was running and was failing because database don't have complete migrations that time.How did I solve it?
Increased the timeout to
10000
from5000
only for integration tests.How to manually test it?
Review checklist