This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
add unique_address constraint for peers table #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referred to postgres docs it is better to have constraints while resolving conflicts during upserts. closes LiskArchive#361 Signed-off-by: Maciej Baj <macie.baj@gmail.com>
4miners
suggested changes
Jan 19, 2017
|
|
||
| ALTER TABLE peers | ||
| ADD CONSTRAINT unique_address | ||
| UNIQUE (ip, port); |
There was a problem hiding this comment.
We already have unique index on those fields, so USING INDEX peers_unique;
Maintaining both unique index and unique constraint is costly and we don't need it.
There was a problem hiding this comment.
so do you have any suggestions?
solutions are:
- not add the constraint and leave the potential errors from upsert
- add the constraint and risk with the performance issues.
Guess that none of these solutions is satisfiable for us.
There was a problem hiding this comment.
ALTER TABLE peers ADD CONSTRAINT unique_address USING INDEX peers_unique; - should be fine, there shouldn't be noticeable performance hit if any.
4miners
approved these changes
Jan 23, 2017
karmacoma
added
ready
and removed
type: test
standards
type: improvement
type: bug
labels
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referred to postgres docs it is better to have constraints while resolving conflicts during upserts.
closes #361