Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

fix BackwardTick promise so it doesn't throws undefined error #391

Merged
merged 3 commits into from
Jan 20, 2017
Merged

fix BackwardTick promise so it doesn't throws undefined error #391

merged 3 commits into from
Jan 20, 2017

Conversation

MaciejBaj
Copy link
Contributor

closes #390

@MaciejBaj MaciejBaj force-pushed the round-backward-tick-fix branch from ce77750 to 11bd4fb Compare January 18, 2017 14:28
4miners
4miners reviewed Jan 19, 2017
View reviewed changes
modules/rounds.js
@@ -106,7 +106,9 @@ Rounds.prototype.backwardTick = function (block, previousBlock, done) {
delete __private.unFeesByRound[round];
delete __private.unRewardsByRound[round];
delete __private.unDelegatesByRound[round];
}).then(promised.markBlockId);
}).then(function () {
promised.markBlockId();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that will works as intended without return here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@karmacoma karmacoma self-assigned this Jan 19, 2017
@karmacoma karmacoma merged commit ad9cd60 into LiskArchive:development Jan 20, 2017
@MaciejBaj MaciejBaj deleted the round-backward-tick-fix branch January 27, 2017 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@4miners 4miners 4miners approved these changes

@karmacoma karmacoma karmacoma approved these changes

Assignees

@karmacoma karmacoma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

this line raise error (this is undefined)
3 participants
@MaciejBaj @karmacoma @4miners