This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix network config - Closes #3466 #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
suggested changes
Apr 30, 2019
| @@ -8,16 +8,13 @@ const defaultConfig = { | |||
| env: 'LISK_WS_PORT', | |||
| arg: '--port,-p', | |||
| }, | |||
| address: { | |||
| hostAddress: { | |||
There was a problem hiding this comment.
Why we need to change the config, not the usage? Similar name used in the http_api module as well, should we change it there as well?
ishantiw
previously approved these changes
Apr 30, 2019
nazarhussain
suggested changes
Apr 30, 2019
Co-Authored-By: shuse2 <shuse2@users.noreply.github.com>
nazarhussain
approved these changes
Apr 30, 2019
ishantiw
approved these changes
Apr 30, 2019
jondubois
approved these changes
Apr 30, 2019
| @@ -439,7 +439,7 @@ | |||
| } | |||
| }, | |||
| "network": { | |||
| "list": [ | |||
| "seedPeers": [ | |||
| { | |||
| "ip": "127.0.0.1", | |||
There was a problem hiding this comment.
Do we want to keep the ip field or rename it to ipAddress to match the p2p library?
Either way is OK for me, just something to think about.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Network config was outdated with the new structure.
How did I fix it?
Update the keys for the network configs and fix the update_config script.
How to test it?
Create sample script to migrate
LISK_NETWORK=mainnet node scripts/update_config.js config_sample.json 1.6.0 2.0.0Also, check the config keys
Review checklist