Add unit tests for signatures module - Closes #2445

[2snEM6]

What was the problem?

Unit tests for signatures module weren't implemented

How did I fix it?

Implemented unit tests for signatures module

How to test it?

npm run mocha -- test/unit/signatures

Review checklist

• The PR resolves Add unit test coverage for signatures module #2445
• All new code is covered with unit tests
• All new code was formatted with Prettier
• Linting passes
• Tests pass
• Commit messages follow the commit guidelines
• Documentation has been added/updated

[2snEM6]

Perhaps I'm wrong but the postSignatures function on the signatures module is not being used anywhere and after discussing with @jondubois it was probably meant for some other case we don't use now. Also, inside the function implementation:

postSignatures(signatures, cb) {
  return modules.transport.shared.postSignatures(
    { signatures },
    (err, res) => {
	__private.processPostResult(err, res, cb);
    }
  );
}

the modules.transport.shared.postSignatures function definition isn't accepting a callback as an argument as expected by the unit tests, it's accepting just an argument called query.

The unit tests skeleton then isn't coherent with the current implementation.

What I did was instead, add unit testing coverage for the postSignature function which is indeed being used.

Also removed outdated unit tests skeletons.

[yatki]

@limiaspasdaniel you are right. There is a new relic definition for postSignatures tho but I think this is just for mapping purpose. @nazarhussain can you take a look and confirm.

You are also right on your comment regarding modules.transport.shared.postSignatures. I don't see any issue with updating test skeletons.

[MaciejBaj]

Why is it important to keep?

[2snEM6]

I added it due to ESLint being picky when not using the last arguments on callback definitions. For example here and here. Also it wouldn't let me type "_" as the name of the arguments to dismiss those errors.

[yatki]

If possible, please do not disable rules on file level. Disable the relevant lines instead with eslint-disable-next-line

[2snEM6]

Fixed

[yatki]

The test skeleton wasn't designed that good before. Please try to refactor it to have hooks and nested suites as less as possible.

[yatki]

If possible, please do not disable rules on file level. Disable the relevant lines instead with eslint-disable-next-line

[2snEM6]

@yatki applied your suggested changes.

[yatki]

Looks very good. Just 2 minor comments.

[2snEM6]

@yatki done, thanks :)

[MaciejBaj]

Good job @limiaspasdaniel and @yatki on the review 👍