This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add functional test coverage for rounds system - Closes #1303 #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaciejBaj @nazarhussain @SargeKhan Comments are done, please review again. |
nazarhussain
approved these changes
Mar 27, 2018
SargeKhan
approved these changes
Mar 27, 2018
test/functional/system/common.js
Outdated
|
|
||
| function forge(library, cb) { | ||
| var keypairs = library.rewiredModules.delegates.__get__('__private.keypairs'); |
| // If account with address exists - set expected values | ||
| if (accounts[address]) { | ||
| // Update sender | ||
| accounts[address].balance = new Bignum(accounts[address].balance) |
There was a problem hiding this comment.
we don't need to minus the transaction amount?
There was a problem hiding this comment.
We need and we do. :)
test/functional/system/rounds.js
Outdated
| }); | ||
| }); | ||
|
|
||
| describe('__private.loadDelegates', () => { |
There was a problem hiding this comment.
why do we have these tests in rounds functional tests?
There was a problem hiding this comment.
Because rounds tests depend on this, before start actual tests would be nice to be sure that delegates were loaded correctly.
There was a problem hiding this comment.
Moved those, together with genesis block tests, to application functional system tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Missing functional system tests for rounds.
How did I fix it?
Add tests.
How to test it?
Run tests.
Review checklist