Validate account logic schema - Closes #1210

[robladbrook]

Closes #1210

I'm not sure if using anyOf introduces any side effects for any other areas of the code using model.filter? As far as I can tell it should be fine.

Note: there is a flakey test on test/unit/logic/account.js which I think was introduced as part of #1211
should throw error when a numeric field receives non numeric value

[LucasIsasmendi]

Hi @robladbrook, thanks for your commits.
The way objectNormalize and schemas are been use in logic components is by defining an X.property.schema with properties and required fields and use it as second parameter when call library.schema.validate() inside of objectNormalize.
Also please note that we are not using es6 yet.

[robladbrook]

@LucasIsasmendi understood. What changes would you like me to make given that the test currently passes?

[LucasIsasmendi]

Test pass, but is not align with what is being used in the rest of the code.
Instead of modify this.model, create Account.prototype.schema and use it for validations:

var report = this.scope.schema.validate(account, Account.prototype.schema);

Check Transaction.prototype.schema from logic/transaction.js as example

[robladbrook]

@LucasIsasmendi do these changes align with what you were thinking?

[LucasIsasmendi]

Thanks @robladbrook, now this is aligned with all the others schema definitions. Some minor changes and it will be approved.

[LucasIsasmendi]

username and u_username should have the same definition and be the same structure as in Delegate.prototype.schema

username: {
  type: 'string',
  format: 'username'
}

[LucasIsasmendi]

Add format: 'id'

[LucasIsasmendi]

Replace case: 'upper' with format: 'address'

[LucasIsasmendi]

secondPublicKey should be the same definition as publicKey

[LucasIsasmendi]

Change related multisig fields to be same as Multisignature.prototype.schema

• multisignatures, u_multisignatures is keygroup
• multimin, u_ multimin is min
• multilifetime, u_ multilifetime is lifetime

[LucasIsasmendi]

Add minimum: 0

[LucasIsasmendi]

Add minimum: 0

[robladbrook]

@LucasIsasmendi I've updated the schema, but the test now fails because the model now requires 1+ in the multisig fields.

Not sure if I should be updating the test model or allowing 0?

[LucasIsasmendi]

@robladbrook please change all min values to 0 in schema definition multisig fields

[robladbrook]

@LucasIsasmendi done!