Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add "transaction applications" (unconfirmed/confirmed) to the same promise chain as Chain.prototype.saveBlock - Closes #1181 #1196

Merged
merged 16 commits into from
Jan 10, 2018
Merged

Add "transaction applications" (unconfirmed/confirmed) to the same promise chain as Chain.prototype.saveBlock - Closes #1181 #1196

merged 16 commits into from
Jan 10, 2018

Conversation

nazarhussain
Copy link
Contributor

Closes: #1181

@karmacoma karmacoma self-assigned this Jan 4, 2018
@vitaly-t
Copy link
Contributor

vitaly-t commented Jan 9, 2018

Never saw anyone hook into transactions that way. Not that it is wrong, just interesting 😄

@nazarhussain
Copy link
Contributor Author

@karmacoma Unit tests are failing on this PR due to issue #1242

karmacoma
karmacoma approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@karmacoma karmacoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @nazarhussain 👍

@karmacoma karmacoma merged commit 9e81e0b into 1.0.0 Jan 10, 2018
@nazarhussain
Copy link
Contributor Author

@karmacoma Thanks

@karmacoma karmacoma deleted the 1181-atomic-block branch January 11, 2018 12:07
@karmacoma karmacoma mentioned this pull request Feb 12, 2018
Closed
2 tasks
shuse2 added a commit that referenced this pull request Apr 15, 2019
@shuse2
Merge pull request #1196 from LiskHQ/1195-correct_order_of_transactions
d1dd3ab 
Fix the order of elements returned from peekUntil and dequeueUntil - Closes #1195
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karmacoma karmacoma karmacoma approved these changes

Assignees

@karmacoma karmacoma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nazarhussain @vitaly-t @karmacoma