Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update vote command #7666

Closed
Tracked by #7622
shuse2 opened this issue Oct 19, 2022 · 0 comments
Closed
Tracked by #7622

Update vote command #7666

shuse2 opened this issue Oct 19, 2022 · 0 comments
Assignees
@has5aan
Labels
framework
Milestone
Sprint 82

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Oct 19, 2022 •
edited
Loading

Description

  • Update vote command to include the events and store usage to the LIP.
  • Check current verify/execute logic is aligned with the LIP

Acceptance Criteria

  • Add tests for new property handling and the events

Additional Information

  • Reward calculation should refer to proposed LIP
@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Oct 19, 2022
@shuse2 shuse2 mentioned this issue Oct 19, 2022
Closed
18 tasks
@shuse2 shuse2 added this to the Sprint 81 milestone Oct 24, 2022
@has5aan has5aan self-assigned this Oct 31, 2022
@shuse2 shuse2 modified the milestones: Sprint 81, Sprint 82 Nov 7, 2022
@has5aan has5aan mentioned this issue Nov 14, 2022
Merged
shuse2 pushed a commit that referenced this issue Nov 17, 2022
@has5aan
Updates vote delegate command (#7777)
59a84fa 
### What was the problem?

This PR resolves #7666 

### How was it solved?

Updated `execute` method for `VoteCommand` to comply with LIP0057.
Created `InternalMethod` for PoS Module to assign rewards.
Defined `calculateVoteRewards` utility function.

### How was it tested?
Implemented unit tests.
@shuse2 shuse2 closed this as completed Nov 18, 2022
Repository owner moved this from Backlog to Done in Lisk SDK Version 6.0.0 Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@has5aan has5aan

Labels
framework
Projects
None yet
Milestone
Sprint 82
Development

No branches or pull requests
2 participants
@shuse2 @has5aan