Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Pass generatorInfo into Commit Pool #6969

Closed
Tracked by #6837
ishantiw opened this issue Jan 3, 2022 · 0 comments · Fixed by #6974
Closed
Tracked by #6837

Pass generatorInfo into Commit Pool #6969

ishantiw opened this issue Jan 3, 2022 · 0 comments · Fixed by #6974
Assignees
Milestone

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Jan 3, 2022

Description

Pass node's generator info into commitPool that required generator Info to identify nonGossiped commits created by the node generator for commit selection process to gossip in the network.

Acceptance Criteria

  • In the periodic job in the commitPool, it should consider nonGossipedCommit created by the node generator for commit selection process to gossip in the network. It should be tested by unit tests.

Additional Information

  • Currently, commitPool doesn't have information about the node generator, so it should be passed through the constructor by the consensus.
@milenagojkovic milenagojkovic added this to the Sprint 60 milestone Jan 3, 2022
@ishantiw ishantiw self-assigned this Jan 6, 2022
@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Jan 7, 2022
@shuse2 shuse2 moved this from Backlog to ToDo in Lisk SDK Version 6.0.0 Jan 7, 2022
@shuse2 shuse2 linked a pull request Jan 12, 2022 that will close this issue
@shuse2 shuse2 moved this from ToDo to Pending Review in Lisk SDK Version 6.0.0 Jan 12, 2022
ishantiw added a commit that referenced this issue Jan 12, 2022
Identify commits created by generator - Closes #6969
Repository owner moved this from Pending Review to Done in Lisk SDK Version 6.0.0 Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants