Functional tests rewrite

[diego-G]

With the new Websocket peer protocol and the incoming API refactoring, it is time to create a cleaner testsuite for functional tests.

• First, we set the next tree folder:

.
+-- test
|   +-- functional
|   |   +-- http
|   |   |   +-- get
|   |   |   +-- post
|   |   +-- ws

• Second, we move the current test/api/transport/ files to test/functional/ws/.

• Third, we move the current test/api/ files to test/functional/http/get/ and we review them in order to leave an skeleton sign for the uncovered parts.

• Fourth, we separate post tests from those files, grouping them per transaction type in files placed onto test/functional/http/post/ folder. Each of them will follow the next workflow template:

  1. Schema validations
  2. Transactions processing
  3. Unconfirmed state
  4. Confirmation:
     • Before new block
     • After new block
  5. Validation
  6. Confirm validation

Due to its extensive nature, we create a task list which will lead to several pull request to solve the whole issue:

---

test/functional/http/get/

• accounts GET Functional tx test type 1 - Subtask 678 #824
• blocks GET PR Refactor Blocks API endpoints to follow REST standards - Closes #861  #887
• dapps GET
• delegates GET Functional tx test type 2 - Subtask 678 #830
• Remove loader GET Remove deprecated endpoint loader - Subtask #678 #937
• multisignatures GET Functional tx test type 4 - Subtask 678 #846
• peers GET Refactor /peers endpoints to use swagger runner interface #925 @nazarhussain
• transactions Functional tx test type 0 - Subtask 678 #822

---

test/functional/http/post/

• Ground PR Functional testsuite restructure #807
• 0.tx POST Functional tx test type 0 - Subtask 678 #822
• 0.tx POST with additional data Functional tx test type 0 with additional data - Subtask 678 #912
• 1.second.secret POST Functional tx test type 1 - Subtask 678 #824
• 1.X.validation/ Decouple validation phase for functional test tx type 1 - Subtask #678 #978
• 1.X.unconfirmed/ Decouple unconfirmed phase from functional test tx type 1 - Subtask #678 #1009
• 2.delegate POST Functional tx test type 2 - Subtask 678 #830
• 3.votes POST Functional tx test type 3 - Subtask 678 #835
• 4.multisig POST Functional tx test type 4 - Subtask 678 #846
• 4.X.validation/ POST Decouple validation phase for functional test tx type 4 - Subtask #678 #979
• 4.X.unconfirmed/ Introduce unconfirmed phase for functional test tx type 4 - Closes #678 #1010
• 5.dapps POST Functional tx test type 5 - Subtask 678 #902
• 6.dapp.inTransfer POST Functional tx test type 6 - Subtask #678 #935
• 7.dapp.outTransfer POST Functional tx test type 7 - Subtask #678 #936

---

test/

• New api helper to get a safe number of blocks to wait New api helper to get a safe number of blocks to wait #888
• New api helper to wait for transactions to be confirmed New api helper to wait for transactions to be confirmed #900

This issue follows #457 in the task list from #225.

[willclarktech]

I would love to get involved in this discussion as I have a lot of strong opinions about functional tests.

[Isabello]

Looks like a great idea.

[diego-G]

As discussed with Oliver, I've changed the structure of the workflow template adding the enforcing phase for types 1 and 4. On the other hand, I will add more tests in the schema phase instead of simply relaying on lisk-js. This will assure the core's api integrity to all the users even for them which won't use lisk-js.