Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Redesign /api/delegates/forging/status endpoint #360

Closed
4miners opened this issue Dec 18, 2016 · 0 comments · Fixed by #363
Closed

Redesign /api/delegates/forging/status endpoint #360

4miners opened this issue Dec 18, 2016 · 0 comments · Fixed by #363
Assignees
@4miners
Labels
type: improvement

Comments

@4miners
Copy link
Contributor

4miners commented Dec 18, 2016 •
edited
Loading

Endpoint /api/delegates/forging/status should be redesigned. I propose following:

  • Endpoint should be private and use same whitelist as /api/delegates/forging/enable and /api/delegates/forging/disable
  • Endpoint without parameters should return enabled status (true/false) and array of delegates public keys that currently forging on node.
  • Endpoint with parameter publicKey stays the same (true/false).
@4miners 4miners mentioned this issue Dec 18, 2016
Closed
@4miners 4miners changed the title Redesign /forging/status endpoint Redesign /api/delegates/forging/status endpoint Dec 18, 2016
@4miners 4miners mentioned this issue Dec 19, 2016
Merged
karmacoma added a commit that referenced this issue Dec 20, 2016
@karmacoma
Merge pull request #363 from 4miners/patch-8
86d79a3 
Redesign /api/delegates/forging/status endpoint.

Closes #360, closes #338.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@4miners 4miners

Labels
type: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redesign /api/delegates/forging/status endpoint 4miners/lisk
2 participants
@karmacoma @4miners