Move TOP=true param. to config.json

[Gr33nDrag0n69]

In order to activate this functionality on the lisk client. The parameter must be pass to nodejs from command line. It would be great if this parameter could be moved to the config.json file with a false value by default. It would prevent having to modify lisk.sh every time I update to enable this functionality for lisk-explorer. (Or any other 3rd party apps wanting to access this functionality.)

[Isabello]

Can you provide some detail about this flag and what it does?

On Sep 30, 2016 17:11, "Gr33nDrag0n" notifications@github.com wrote:

In order to activate this functionality on the lisk client. The parameter
must be pass to nodejs from command line. It would be great if this
parameter could be moved n the config.json file with a false value by
default. It would prevent having to modify lisk.sh every time I update to
enable this functionality for lisk-explorer. (Or any other 3rd party apps
wanting to access this functionality.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#285, or mute the thread
https://github.com/notifications/unsubscribe-auth/APzFsKMe65I0KvCmOA_S_ntJebvbibnoks5qvYj4gaJpZM4KLjpR
.

[Gr33nDrag0n69]

In order for this page of lisk-explorer to work as expected, I need to do the following modification in lisk.sh each upgrade. I don't wan't to use a sed replace for it since I feel that this particulatr line starting lisk app.js can be modified anytime. Using a jq command would make it simpler and cleaner.

https://testnet-explorer.lisknode.io/topAccounts

vi lisk.sh
#--------------------------------------------------------------------
# In start_lisk() function, replace
forever start -u lisk -a -l $LOG_FILE --pidFile $PID_FILE -m 1 app.js -c $LISK_CONFIG &> /dev/null
# By
TOP=true forever start -u lisk -a -l $LOG_FILE --pidFile $PID_FILE -m 1 app.js -c $LISK_CONFIG &> /dev/null
#--------------------------------------------------------------------

[karmacoma]

@Gr33nDrag0n69: Thanks for your suggestion. Yes we will implement. I agree it would better to enable / disable this option within config.json, rather than as an environment variable.

[Gr33nDrag0n69]

@karmacoma thanxs greatly appreciated. It's the only option I know that can only be enabled from env. var. I don't know if there is others options but maybe check for that too while being at it. Moving all of them at once would probably save some time later.

[ghost]

Duplicated. I have already reported that one before
#234

But there is flag - Won't fix.

[karmacoma]

@karek314 Okay this issue was closed, and should not have been. We will fix here now. Thanks 👍

[Isabello]

I will resolve this shortly.