Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add "round ticks" (forwards/backwards) to the same promise chain as Chain.prototype.saveBlock #1297

Closed
karmacoma opened this issue Jan 12, 2018 · 3 comments
Assignees

Comments

@karmacoma
Copy link
Contributor

karmacoma commented Jan 12, 2018

Parent: #302

Continuation of: #1181

Current behavior

BEGIN DB TRANSACTION
  Apply unconfirmed transaction
  Apply confirmed transaction
  Insert block
  Insert transaction
  Insert transaction type
COMMIT

BEGIN DB TRANSACTION
  Round tick
COMMIT

Proposed behavior

BEGIN DB TRANSACTION
  Apply unconfirmed transaction
  Apply confirmed transaction
  Insert block
  Insert transaction
  Insert transaction type
  Round tick
COMMIT

Code Target

https://github.com/LiskHQ/lisk/blob/development/logic/round.js
https://github.com/LiskHQ/lisk/blob/development/modules/rounds.js

@nazarhussain
Copy link
Contributor

nazarhussain commented Jan 12, 2018

@karmacoma After closing #1181 the current behaviour is:

BEGIN DB TRANSACTION
  Apply unconfirmed transaction
  Apply confirmed transaction
  Insert block
  Insert transaction
  Insert transaction type
  BEGIN DB TRANSACTION
      Round tick
  COMMIT
COMMIT

@vitaly-t
Copy link
Contributor

vitaly-t commented Jan 16, 2018

It is currently on hold, as we have absolutely no tests for that functionality, while the change seems trivial.

@karmacoma karmacoma added *medium and removed *hard labels Jan 29, 2018
@4miners 4miners assigned 4miners and unassigned vitaly-t Feb 7, 2018
@4miners
Copy link
Contributor

4miners commented Feb 7, 2018

@vitaly-t I reasigned it, as I need it fixed for #1303

Behavior described in #1297 (comment) is not valid, it still uses different connection handler for tick - so round logic don't see block that is already saved to database (in different SQL transaction).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants