Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add peers table migration supporting port to wsPort rename #1167

Closed
MaciejBaj opened this issue Dec 19, 2017 · 0 comments
Closed

Add peers table migration supporting port to wsPort rename #1167

MaciejBaj opened this issue Dec 19, 2017 · 0 comments
Assignees
@nazarhussain
Labels
type: bug

Comments

@MaciejBaj
Copy link
Contributor

MaciejBaj commented Dec 19, 2017 •
edited
Loading

Current behaviour

After #855 is done every time when application exits and peers list is not empty, following error is thrown:

[ERR] 2017-12-19 16:22:57 | Export peers to database failed - {"error":"ERROR:  column \"wsPort\" of relation \"peers\" does not exist\nLINE 1: insert into \"peers\"(\"ip\",\"wsPort\",\"state\",\"height\",\"os\",\"version"}

Dumping peers to database after node shutdown doesn't work anymore.

Expected behaviour

The database migration to reflect the property http to wsHttp rename is needed. Node should be able to dump peers list to database in order to insert them again during the next start.
@karmacoma karmacoma assigned MaciejBaj and nazarhussain and unassigned MaciejBaj Jan 1, 2018
@nazarhussain nazarhussain mentioned this issue Jan 2, 2018
Merged
@karmacoma karmacoma reopened this Jan 2, 2018
shuse2 added a commit that referenced this issue Apr 15, 2019
@shuse2
Merge pull request #1167 from LiskHQ/1166-return_queue_name_with_add_…
0368b94 
…transaction_result

When adding transaction, the transaction pool should return the name of the queue along with the status - Closes #1166
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nazarhussain nazarhussain

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karmacoma @nazarhussain @MaciejBaj