Blockchain:hash returns incorrect hash (#9150)

* Fix data stream * Update unit test * Close db upon finish * Fix unit test per update
LiskArchive · Nov 24, 2023 · c610d8c · c610d8c
1 parent f825978
commit c610d8c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/commander/src/bootstrapping/commands/blockchain/hash.ts b/commander/src/bootstrapping/commands/blockchain/hash.ts
@@ -54,8 +54,8 @@ export class HashCommand extends Command {
 		const dbHash = crypto.createHash('sha256');
 
 		const hash: Buffer = await new Promise((resolve, reject) => {
-			stream.on('data', (chunk: Buffer) => {
-				dbHash.update(chunk);
+			stream.on('data', ({ value }: { key: Buffer; value: Buffer }) => {
+				dbHash.update(value);
 			});
 
 			stream.on('error', error => {
@@ -68,7 +68,7 @@ export class HashCommand extends Command {
 		});
 
 		this.debug('Hash generation completed.');
-
 		this.log(hash.toString('hex'));
+		db.close();
 	}
 }
diff --git a/commander/test/bootstrapping/commands/blockchain/hash.spec.ts b/commander/test/bootstrapping/commands/blockchain/hash.spec.ts
@@ -46,7 +46,14 @@ describe('blockchain:hash', () => {
 		};
 		jest.spyOn(crypto, 'createHash').mockReturnValue(hashStub as never);
 		jest.spyOn(dbUtils, 'getBlockchainDB').mockReturnValue({
-			createReadStream: jest.fn().mockReturnValue(Readable.from([hashBuffer])),
+			createReadStream: jest.fn().mockReturnValue(
+				Readable.from([
+					{
+						value: hashBuffer,
+					},
+				]),
+			),
+			close: jest.fn(),
 		} as never);
 		jest.spyOn(appUtils, 'getPid').mockReturnValue(pid);
 	});