Prefer conversion to Buffer in application layer for data filter

modules/transactions.js

@@ -105,7 +105,7 @@ __private.list = function(filter, cb) {
 
 	// Removing null characters from data filter to avoid errors in pg-promise library
 	if (filter.data) {
-		filter.data = filter.data.replace(/\0/g, '');
+		filter.data = Buffer.from(filter.data);
 	}
 
 	const allowedFieldsMap = {
@@ -128,7 +128,7 @@ __private.list = function(filter, cb) {
 		type: '"t_type" = ${type}',
 		minConfirmations: 'confirmations >= ${minConfirmations}',
 		data:
-			't_id IN (SELECT transfer."transactionId" FROM transfer WHERE transfer.data LIKE ${data}::bytea)',
+			't_id IN (SELECT transfer."transactionId" FROM transfer WHERE transfer.data LIKE ${data})',
 		limit: null,
 		offset: null,
 		sort: null,

test/functional/http/get/transactions.js

@@ -706,32 +706,6 @@ describe('GET /api/transactions', () => {
 					});
 			});
 
-			it('using unicode null character with regex should return all the transactions', () => {
-				var dataFilter = '%\u0000%';
-				var count;
-				return transactionsEndpoint
-					.makeRequest(
-						{
-							data: '%',
-						},
-						200
-					)
-					.then(res => {
-						count = res.body.meta.count;
-					})
-					.then(() => {
-						return transactionsEndpoint.makeRequest(
-							{
-								data: dataFilter,
-							},
-							200
-						);
-					})
-					.then(res => {
-						expect(res.body.meta.count).to.equal(count);
-					});
-			});
-
 			it('using unicode character should return transactions', () => {
 				var unicodeCharacter = '฿';
 				var fuzzyCommand = '%';
@@ -743,7 +717,7 @@ describe('GET /api/transactions', () => {
 						200
 					)
 					.then(res => {
-						expect(res.body.data.length).to.greaterThan(1);
+						expect(res.body.data.length).to.greaterThan(0);
 						_.map(res.body.data, transaction => {
 							return expect(transaction.asset.data).to.include(
 								unicodeCharacter