This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Improve sign/verify message ui - Closes #150 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
force-pushed
the
150-improve-sign-message-ui
branch
from
6d39e24 to
a90638f
Compare
slaweet
suggested changes
Jun 2, 2017
| @@ -1,4 +1,5 @@ | |||
| import lisk from 'lisk-js'; | |||
| import './sign-message.less'; | |||
There was a problem hiding this comment.
Just for the sake of readability I would do this import also in src/components/signVerify/verifyMessage.js
And also rename sign-message.less to signVerifyMessage.less
There was a problem hiding this comment.
Thought it's redundant, but I've added.
|
I don't like the way action bar looks in signMessage, but currently nothing comes into my mind. @slaweet let me know if you have any suggestions. |
... and hide it after result shown
|
@reyraa I tried to improve how the action bar looks, in a commit to this branch. |
slaweet
approved these changes
Jun 2, 2017
karmacoma
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150