This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Syntax and documentation improvements in passphrase utility #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 7, 2018 15:58
This code selects a random array index from `available` or `byte`. The formular for this operation is `Math.floor(Math.random()*items.length)` (see https://stackoverflow.com/a/5915122). In the current code, Math.floor is replaced with parseInt, which is meant to convert a string, not a floating point number. Since parseInt converts a number to a string first, the result will be the same in most cases. However, parseInt is not the right tool in this place. MDN excplicitly warns: "parseInt should not be used as a substitute for Math.floor()" (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt)
The value of the variable is not the bit (0 or 1) but the index in the array `byte`.
parseInt(`0x${num}`, 10) is always 0 for any hex string `num`.
Before, an empty array from generateSeed() would make this test pass.
|
Thanks for the PRs @webmaster128 |
|
@slaweet sure, no problem. Let me know when you fixed development. Then I can rebase my PRs such that everything is nice and clean. |
|
@slaweet Any updates on Nano's CI health? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR containing the exact same commits from LiskHQ/lisk-desktop#654. Since the files did not change much between nano and hub, no merges were necessary