Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #536 - introduce examples to the Swagger/OpenAPI #538

Merged
merged 3 commits into from
Dec 24, 2019
Merged

Conversation

lmsurpre
Copy link
Member

By default, we'll now use the first complete-mock example for each
applicable resourceType.

In addition, I flipped this to "minimal" and used that to generate a new
version of the "all-in-one" in our fhir-openapi project.

Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com

@lmsurpre lmsurpre requested a review from prb112 December 24, 2019 00:01
By default, we'll now use the first `complete-mock` example for each
applicable resourceType.

In addition, I flipped this to "minimal" and used that to generate a new
version of the "all-in-one" in our `fhir-openapi` project.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre changed the base branch from lee-master to master December 24, 2019 00:05
@prb112 prb112 added this to the Sprint 6 milestone Dec 24, 2019
<groupId>${project.groupId}</groupId>
<artifactId>fhir-examples</artifactId>
<version>${project.version}</version>
<scope>compile</scope>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not picked up in any other project? if so, we may want to add an exclusion.

Double checking with this comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing else should depend on this one...its basically an independent project for making some swagger / openapi definitions (similar to fhir-tools, except that it depends on fhir-model).

@@ -3,7 +3,7 @@
"openapi": "3.0.0",
"info": {
"title": "Simplified FHIR API",
"description": "A simplified version of the FHIR API",
"description": "A simplified version of the HL7 FHIR API",
"version": "4.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the title match our IBM FHIR Server? or update to 4.0.1 to match the spec?

Copy link
Member Author

@lmsurpre lmsurpre Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is mostly independent of our implementation...we don't have our own "flavor" of FHIR. However, due to complexities with representing FHIR in Swagger/OpenAPI, this is not a representation of the full FHIR API. This is why I settled on "A simplified version of the HL7 FHIR API".

However, I do agree that we should update it to say version 4.0.1.

Also, I've been meaning to add a README for this module so that others can have some clue about what it does...I'll try adding that tonight and so please hold off on merging this one for now.

Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. added support for `@throws` javadoc annotation in CodeBuilder
2. used this to add `@throws` documentation for Resource.as and
Element.as

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmsurpre lmsurpre merged commit 8154257 into master Dec 24, 2019
@lmsurpre lmsurpre deleted the issue-536 branch December 24, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants