issue #4101 - handle patch in fhir-smart interceptor #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add corresponding tests to AuthzPolicyEnforcementTest.java Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
fhir-smart/src/test/java/org/linuxforhealth/fhir/smart/test/AuthzPolicyEnforcementTest.java
Outdated
Show resolved
Hide resolved
lmsurpre
commented
Dec 6, 2022
fhir-smart/src/test/java/org/linuxforhealth/fhir/smart/test/AuthzPolicyEnforcementTest.java
Outdated
Show resolved
Hide resolved
as suggested Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
punktilious
reviewed
Dec 8, 2022
| assertTrue(shouldSucceed(resourceTypesPermittedByScope, OBSERVATION, READ_APPROVED, permission) && | ||
| shouldSucceed(resourceTypesPermittedByScope, OBSERVATION, WRITE_APPROVED, permission)); | ||
| } catch (FHIRPersistenceInterceptorException e) { | ||
| assertFalse(shouldSucceed(resourceTypesPermittedByScope, OBSERVATION, READ_APPROVED, permission) && |
There was a problem hiding this comment.
should this be an || instead of && ?
I'm assuming you want both of these to be false.
There was a problem hiding this comment.
I think the && is right. If either one of these is false, then we expect the method under test to throw a FHIRPersistenceInterceptorException.
punktilious
reviewed
Dec 8, 2022
| if (shouldSucceed(resourceTypesPermittedByScope, BINARY, READ_APPROVED, permission) && | ||
| shouldSucceed(resourceTypesPermittedByScope, BINARY, WRITE_APPROVED, permission)) { | ||
| assertTrue(e.getMessage().equals("securityContext is not supported for resource type Binary")); | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| // else beforePatch was rejected due to normal fhir-smart behavior (non-securityContext-related) |
as requested in review Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add corresponding tests to AuthzPolicyEnforcementTest.java
Signed-off-by: Lee Surprenant lmsurpre@merative.com