issue #3712 - check all CodeSystem concept designations #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Split `validateDisplay` into two flavors; now validateCode(CodeSystem, Coding, ValidationParameters) will use the passed CodeSystem to determine case sensitivity (instead of looking it up via the registry) 2. When the Coding.display doesn't match the lookup display, we now look for a match within the CodesSystem.concept.designation values before calling it invalid. 3. Added a designation to a couple sample code systems and added testValidateDisplay tests for both case-sensitive and case-insensitive behavior. Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
punktilious
reviewed
Jul 12, 2022
term/fhir-term/src/main/java/com/ibm/fhir/term/service/FHIRTermService.java
Show resolved
Hide resolved
punktilious
reviewed
Jul 12, 2022
term/fhir-term/src/main/java/com/ibm/fhir/term/service/FHIRTermService.java
Outdated
Show resolved
Hide resolved
punktilious
reviewed
Jul 12, 2022
term/fhir-term/src/main/java/com/ibm/fhir/term/service/FHIRTermService.java
Show resolved
Hide resolved
lmsurpre
commented
Jul 12, 2022
term/fhir-term/src/main/java/com/ibm/fhir/term/service/FHIRTermService.java
Outdated
Show resolved
Hide resolved
lmsurpre
commented
Jul 12, 2022
term/fhir-term/src/main/java/com/ibm/fhir/term/service/FHIRTermService.java
Show resolved
Hide resolved
Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
validateDisplayinto two flavors; nowvalidateCode(CodeSystem, Coding, ValidationParameters) will use the
passed CodeSystem to determine case sensitivity (instead of looking it
up via the registry)
When the Coding.display doesn't match the lookup display, we now look
for a match within the CodesSystem.concept.designation values before
calling it invalid.
Added a designation to a couple sample code systems and added
testValidateDisplay tests for both case-sensitive and case-insensitive
behavior.
Signed-off-by: Lee Surprenant lmsurpre@merative.com