issue #3501 - apply fix for #2965 more universally #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
force-pushed
the
issue-3390
branch
2 times, most recently
from
3c249c0 to
bd3b1f4
Compare
We had duplicate logic in two classes: * FHIRResource.getRequestBaseUri * FHIRRestHelper.getRequestBaseUri For #2965, we fixed the version in FHIRResource but missed the one in FHIRRestHelper. Now I combined the two implementations into FHIRRestHelper, made it static, and removed the version from FHIRResource. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
For both `Entry.fullUrl` and `Entry.response.location`. I also added the etag element to the Entry.response objects to be more consistent with the instance-level history implementation. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
1. add Entry.response.location to instance-history response 2. set 201 for the initial create entry (we need #3507 for the undelete case) 3. remove the status code name from Entry.response.status for system and type-level history interactions (e.g. `200 OK` -> `200`) Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had duplicate logic in two classes:
For #2965, we fixed the version in FHIRResource but missed the one in
FHIRRestHelper.
Now I combined the two implementations into FHIRRestHelper, made it
static, and removed the version from FHIRResource.
I also added commits for the discrepencies between system-level and
instance-level history identified in #3501
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com