Issue #3276 - Fix NPE in fhir-smart beforeDelete #3292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jornvanwier
force-pushed
the
issue-3276-NullPointerException-when-deleting-resource-with-fhir-smart-enabled
branch
from
9fe5771 to
46a5379
Compare
Use event.getFhirResource() instead of event.getPrevResource() in beforeDelete method of fhir-smart. Signed-off-by: Jorn van Wier <mail@jornvanwier.com>
jornvanwier
force-pushed
the
issue-3276-NullPointerException-when-deleting-resource-with-fhir-smart-enabled
branch
from
46a5379 to
e629265
Compare
jornvanwier
deleted the
issue-3276-NullPointerException-when-deleting-resource-with-fhir-smart-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
event.getFhirResource()instead ofevent.getPrevResource()in beforeDelete method of fhir-smart.FHIRRestHelper.doDeletesends an event with onlyevent.setFhirResource(), notevent.setPrevFhirResource(). I assume that the code inFHIRRestHelperis correct given that it is used in more places, so I changed the code infhir-smartto get the correct resource from the event.If this is not the correct solution I'd be happy to make changes.