Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search for related resources and make extra resources in patient $everything configurable #3243

Merged
merged 36 commits into from
Feb 7, 2022
Merged

Add search for related resources and make extra resources in patient $everything configurable #3243

merged 36 commits into from
Feb 7, 2022
+1,109 −349

Conversation

sfc42
Copy link
Contributor

@sfc42 sfc42 commented Jan 24, 2022

Add search for related resources and make extra resources in patient $everything configurable

Signed-off-by: Susan Crowell sfc@us.ibm.com

@sfc42 sfc42 mentioned this pull request Jan 25, 2022
Closed
sfc42 added 7 commits January 26, 2022 13:07
@sfc42
Add a Location that is not a searchParameter to the server example
67c84a9 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Add support to pick up Location/Medication/Organization/Practitioner
d1a75f5 
that are not search parameters

Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Add missing parameter to EoB search
3d376f1 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Need to make sure we don't have duplicate entries with _includes
dbb529e 
searches

Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Fill in Entry fullUrl
72b550b 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Update fhir-server-config used by testcases to have all extra resources
45aa876 
returned for $everything

Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Add search for related resources and make extra resources in patient …
9af4b85 
…$everything configurable

Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42 sfc42 force-pushed the issue-2337-2 branch 6 times, most recently from 0810be4 to 0b50e0e Compare February 1, 2022 14:41
sfc42 and others added 3 commits February 1, 2022 09:49
@sfc42 @prb112
Update operation/fhir-operation-everything/src/main/java/com/ibm/fhir…
3195c88 
…/operation/everything/EverythingOperation.java

Co-authored-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42 @prb112
Update operation/fhir-operation-everything/src/main/java/com/ibm/fhir…
5d93b66 
…/operation/everything/EverythingOperation.java

Co-authored-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Add needed types for patient $everything to derby-bootstrap.sh
fd86759 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
sfc42 added 6 commits February 3, 2022 08:58
@sfc42
Remove trailing whitespace
97f0032 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Address code review comments for EverythingOperationTenant1Test
f0f9388 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Code review comment for fhir-server-config.json
ce89968 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Address code review comments
56bbc18 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Change testcase
ab38aec 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Address code review comments
f85a877 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Need null check for servers that don't have operations->everything
2b0465c 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
@sfc42
Addressing code review comments
8b8897c 
Signed-off-by: Susan Crowell <sfc@us.ibm.com>
lmsurpre
lmsurpre approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prb112
prb112 approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@prb112 prb112 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feels like EverythingOperation may need to be refactored at some point for maintainability.

@prb112 prb112 merged commit b180bb8 into main Feb 7, 2022
@prb112 prb112 deleted the issue-2337-2 branch February 7, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmsurpre lmsurpre lmsurpre approved these changes

@prb112 prb112 prb112 approved these changes

@tbieste tbieste Awaiting requested review from tbieste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc42 @prb112 @lmsurpre