Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out the Term Graph Loaders #2806 #2813

Merged
merged 5 commits into from
Sep 27, 2021
Merged

Split out the Term Graph Loaders #2806 #2813

merged 5 commits into from
Sep 27, 2021

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Sep 27, 2021

  • refactor the pom module
  • split loader and graph

Signed-off-by: Paul Bastide pbastide@us.ibm.com

- refactor the pom module
- split loader and graph

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 requested a review from lmsurpre September 27, 2021 12:51
@prb112 prb112 self-assigned this Sep 27, 2021
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very glad to have the loader separated from the termProvider. I'm not sure we needed to move all term-related projects into a subdirectory, but I'm fine with it. LGTM.

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@lmsurpre lmsurpre added the new-module Flag for identifying PRs that introduce a new module (and therefor require manual work for release) label Sep 27, 2021
@lmsurpre
Copy link
Member

I missed it / forgot about it in my first review, but we should also update the README to reflect this new module (and the updated paths to the term modules)

@prb112 prb112 added the ci-skip Skips the CI Build label Sep 27, 2021
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 merged commit 0f07c83 into main Sep 27, 2021
@prb112 prb112 deleted the issue-2806 branch September 27, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation automation ci-skip Skips the CI Build new-module Flag for identifying PRs that introduce a new module (and therefor require manual work for release) terminology
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants