-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #2155 - Use hash to determine if search parameters need update #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbieste
force-pushed
the
tbieste-issue-2155
branch
6 times, most recently
from
June 18, 2021 16:18
76099c5
to
be87616
Compare
tbieste
force-pushed
the
tbieste-issue-2155
branch
2 times, most recently
from
June 25, 2021 16:55
70c9347
to
c78b02b
Compare
tbieste
force-pushed
the
tbieste-issue-2155
branch
from
June 25, 2021 20:22
c78b02b
to
fddb93d
Compare
punktilious
reviewed
Jun 28, 2021
fhir-persistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dao/ReindexResourceDAO.java
Outdated
Show resolved
Hide resolved
punktilious
reviewed
Jun 28, 2021
fhir-persistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dto/DateParmVal.java
Outdated
Show resolved
Hide resolved
punktilious
reviewed
Jun 28, 2021
fhir-persistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dto/LocationParmVal.java
Outdated
Show resolved
Hide resolved
punktilious
reviewed
Jun 28, 2021
...rsistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/impl/FHIRPersistenceJDBCImpl.java
Outdated
Show resolved
Hide resolved
punktilious
reviewed
Jun 28, 2021
fhir-persistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/util/ParameterHashUtil.java
Outdated
Show resolved
Hide resolved
punktilious
reviewed
Jun 28, 2021
...stence-jdbc/src/test/java/com/ibm/fhir/persistence/jdbc/test/util/ParameterHashUtilTest.java
Outdated
Show resolved
Hide resolved
tbieste
force-pushed
the
tbieste-issue-2155
branch
2 times, most recently
from
June 28, 2021 20:58
504830d
to
43afc34
Compare
punktilious
reviewed
Jun 30, 2021
...ersistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dto/ExtractedParameterValue.java
Show resolved
Hide resolved
punktilious
reviewed
Jun 30, 2021
...istence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/util/ExtractedSearchParameters.java
Outdated
Show resolved
Hide resolved
punktilious
reviewed
Jun 30, 2021
...-persistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/util/ParameterHashVisitor.java
Show resolved
Hide resolved
punktilious
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of minor comments/suggestions.
tbieste
force-pushed
the
tbieste-issue-2155
branch
from
June 30, 2021 17:28
9c70205
to
3840354
Compare
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
force-pushed
the
tbieste-issue-2155
branch
from
June 30, 2021 18:51
3840354
to
37a045a
Compare
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2155 - Use hash to determine if search parameters need update
Signed-off-by: Troy Biesterfeld tbieste@us.ibm.com